Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix order of policy report generation #314

Merged
merged 1 commit into from
May 24, 2023

Conversation

Vyom-Yadav
Copy link
Contributor

Signed-off-by: Vyom-Yadav jackhammervyom@gmail.com


Items:

  • The order of report generation varied as we traversed the set using a for loop. The missing case was: adding an admission controller policy record to the report when report generation was not started which is now fixed.
  • Now respects namespace filter for admission controller policies and does not generate admission controller policies based on a static image filter (eg - nginx). The image filter generates policies after pulling a particular image, not based on deployments.
  • Also fixes adding Audit or Enforce or Block label to the report, severity (-/10 -> -), and the policy type name Kubearmor Security Policy -> Kyverno Policy for kyverno policies.

@Vyom-Yadav

This comment was marked as outdated.

Signed-off-by: Vyom-Yadav <jackhammervyom@gmail.com>
Copy link
Member

@daemon1024 daemon1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

A small query below, let's include that detail in the PR for future ref, rest seemed self explanatory

recommend/html/record.html Show resolved Hide resolved
@daemon1024 daemon1024 merged commit bea659a into kubearmor:main May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants